close spotbugs#259: ensure that reported problem is already fixed in …

…SpotBugs

spotbugs-tests/src/test/java/edu/umd/cs/findbugs/nullness/Issue259Test.java

@@ -0,0 +1,26 @@
+package edu.umd.cs.findbugs.nullness;
+
+import edu.umd.cs.findbugs.BugCollection;
+import edu.umd.cs.findbugs.test.SpotBugsRule;
+import org.junit.Rule;
+import org.junit.Test;
+
+import java.nio.file.Paths;
+
+import static org.hamcrest.Matchers.emptyIterable;
+import static org.junit.Assert.assertThat;
+
+/**
+ * Unit test to reproduce <a href="https://github.com/spotbugs/spotbugs/issues/259">#259</a>.
+ */
+public class Issue259Test {
+    @Rule
+    public SpotBugsRule spotbugs = new SpotBugsRule();
+
+    @Test
+    public void test() {
+        BugCollection bugCollection = spotbugs.performAnalysis(
+                Paths.get("../spotbugsTestCases/build/classes/java/main/ghIssues/Issue259.class"));
+        assertThat(bugCollection, emptyIterable());
+    }
+}

spotbugsTestCases/src/java/ghIssues/Issue259.java

@@ -0,0 +1,15 @@
+package ghIssues;
+
+public class Issue259 {
+    public void falsePositive() {
+        try (X x = new X(); X y = new X()) {
+            throw new IllegalStateException();
+        } // Redundant nullcheck of x, which is known to be non-null in test.Bug1169.falsePositive()
+    }
+
+    private static class X implements AutoCloseable {
+        @Override
+        public void close() {
+        }
+    }
+}