Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the extern directory #509

Closed
12 tasks done
Kenix3 opened this issue Apr 24, 2024 · 2 comments · Fixed by #561
Closed
12 tasks done

Clean up the extern directory #509

Kenix3 opened this issue Apr 24, 2024 · 2 comments · Fixed by #561
Assignees
Milestone

Comments

@Kenix3
Copy link
Owner

Kenix3 commented Apr 24, 2024

We should not be relying on any external repositories committed into LUS.

Supercedes #500

@Kenix3 Kenix3 added this to the LUS 2.0.0 milestone Apr 24, 2024
@briaguya-ai
Copy link
Collaborator

see #374 for imgui stuff - i see 2 options for paths forward here

either

or

@Archez
Copy link
Contributor

Archez commented Apr 24, 2024

metal-cpp is made by Apple and provided as a download zip from their domain, different versions are listed in their landing page https://developer.apple.com/metal/cpp/

There are some clones of these files on github by various users. I don't know if we want to trust one of these github clones, or pull directly from Apple as a .zip/extract.

It looks like we use the "single header" alternative, which requires executing a python script provided in the .zip to generate the resulting header file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants