Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed soh on atmosphere 16.0.0 #145

Merged
merged 1 commit into from Mar 13, 2023
Merged

Conversation

KiritoDv
Copy link
Contributor

No description provided.

@liamwhite
Copy link

Fixes #133

@leggettc18
Copy link
Contributor

From my testing, it seems like this will cause SoH not to work for anyone with a pre 16.0.0 switch. Is there a way we can read the firmware version at runtime to fall-back to the current service type?

@liamwhite
Copy link

@leggettc18 You're not supposed to be using pl:s in the first place, and it should be fine for SoH to have a session to pl:u since it runs as application anyway. Do you have other software installed that might be taking a session, like Tesla menu?

@leggettc18
Copy link
Contributor

Oh looks like SoH's current nightly switch build has the same issue so I guess this change isn't the cause. I'm not sure what would be having a session on my switch though. sys-ftpd maybe?

@leggettc18
Copy link
Contributor

Well due to a series of unfortunate events I'm no longer confident that I didn't have some other problem on my end and can now no longer test with pre-16.0.0 firmware :(

@liamwhite
Copy link

I tested this patch with my 15.0.1 Switch, and it worked fine.

@Kenix3 Kenix3 merged commit b13adb3 into Kenix3:main Mar 13, 2023
briaguya-ai pushed a commit to briaguya-ai/libultraship that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants