Feature/switch-controllers on main #96
Conversation
This reverts parts of 503ab19d3d4253fb013752572c19c314d19de792 which massively impacted loading times.
* Speed up CRC map generation * Remove unused helpers * Clean up var names * Fix formatting
KiritoDv
force-pushed
the
feature/switch-on-main
branch
2 times, most recently
from
d9645a7
to
f4fafa6
Compare
Kenix3
force-pushed
the
main
branch
3 times, most recently
from
b54cbcb
to
ace0c03
Compare
|
Left this comment on the SoH PR, also leaving it here in case it's more visible here. This works great on my Switch apart from one small issue. If I attempt to use a pro controller while in handheld mode, the inputs go through just fine but rumble and Gyro stay on the joycons. They both work fine on the Pro Controller when the switch is docked, and they work great with the joycons in handheld mode, but I do sometimes find myself setting my switch up on my desk and playing with a pro controller with the Switch in handheld mode, would be nice if that would work. I think always using the pro controller for Rumble and Gyro if one is connected would be the ideal solution. |
| @@ -1046,7 +1046,8 @@ enum ImGuiInputTextFlags_ | |||
| ImGuiInputTextFlags_NoUndoRedo = 1 << 16, // Disable undo/redo. Note that input text owns the text data while active, if you want to provide your own undo/redo stack you need e.g. to call ClearActiveID(). | |||
| ImGuiInputTextFlags_CharsScientific = 1 << 17, // Allow 0123456789.+-*/eE (Scientific notation input) | |||
| ImGuiInputTextFlags_CallbackResize = 1 << 18, // Callback on buffer capacity changes request (beyond 'buf_size' parameter value), allowing the string to grow. Notify when the string wants to be resized (for string types which hold a cache of their Size). You will be provided a new BufSize in the callback and NEED to honor it. (see misc/cpp/imgui_stdlib.h for an example of using this) | |||
| ImGuiInputTextFlags_CallbackEdit = 1 << 19 // Callback on any edit (note that InputText() already returns true on edit, the callback is useful mainly to manipulate the underlying buffer while focus is active) | |||
| ImGuiInputTextFlags_CallbackEdit = 1 << 19, // Callback on any edit (note that InputText() already returns true on edit, the callback is useful mainly to manipulate the underlying buffer while focus is active) | |||
| ImGuiInputTextFlags_NoPlusMinusButtons = 1 << 20 // Disable increment/decrement buttons | |||
|
I tested this using HarbourMasters/Shipwright#2444 First I merged in latest LUS, this exists on https://github.com/briaguya-ai/libultraship/tree/update-switch-on-main In my testing, I found:
@KiritoDv these issues will need to be addressed before this can be considered ready to merge. |
Kenix3
force-pushed
the
main
branch
2 times, most recently
from
a3f18f7
to
c946c2c
Compare
|
While we want the changes, this will have to be redone under the new controller system. Feel free to open a new PR to do that. |
No description provided.