Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/export metric parser interface #20

Merged
merged 15 commits into from Apr 6, 2018

Conversation

KennethanCeyer
Copy link
Owner

@KennethanCeyer KennethanCeyer commented Apr 6, 2018

change

  • update metric-parser version
  • add export keyword for metric-parser types (tree, ast)
  • update npm version
  • update dist, typedoc files
  • add unit test with dom

@coveralls
Copy link

coveralls commented Apr 6, 2018

Pull Request Test Coverage Report for Build 207

  • 9 of 14 (64.29%) changed or added relevant lines in 4 files are covered.
  • 129 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+17.1%) to 30.373%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ui/ui.manager.ts 0 1 0.0%
src/ui/ui.dom.ts 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
src/ui/ui.base.ts 2 22.22%
src/ui/ui.pipe.ts 2 26.09%
src/token.helper.ts 2 65.22%
src/ui/ui.hook.ts 2 25.0%
src/ui/ui.dom.ts 14 20.27%
src/ui/ui.ts 16 17.65%
src/ui/ui.manager.ts 91 9.26%
Totals Coverage Status
Change from base Build 184: 17.1%
Covered Lines: 283
Relevant Lines: 723

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Apr 6, 2018

Codecov Report

Merging #20 into master will increase coverage by 19.38%.
The diff coverage is 52.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #20       +/-   ##
===========================================
+ Coverage   17.83%   37.21%   +19.38%     
===========================================
  Files          19       19               
  Lines         830      739       -91     
  Branches      118       98       -20     
===========================================
+ Hits          148      275      +127     
+ Misses        682      463      -219     
- Partials        0        1        +1
Impacted Files Coverage Δ
src/ui/ui.dom.ts 22.95% <0%> (+22.95%) ⬆️
src/ui/ui.manager.ts 11.82% <0%> (+11.82%) ⬆️
src/global.ts 66.66% <100%> (ø) ⬆️
src/ui/ui.element.helper.ts 100% <100%> (+100%) ⬆️
src/string.helper.ts 83.33% <0%> (+16.66%) ⬆️
src/ui/ui.ts 18.75% <0%> (+18.75%) ⬆️
src/ui/ui.base.ts 33.33% <0%> (+33.33%) ⬆️
src/ui/ui.hook.ts 35.71% <0%> (+35.71%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c237dbd...6697f9b. Read the comment docs.

@KennethanCeyer KennethanCeyer changed the title WIP: feature/export metric parser interface feature/export metric parser interface Apr 6, 2018
@KennethanCeyer KennethanCeyer merged commit 86e411a into master Apr 6, 2018
@KennethanCeyer KennethanCeyer deleted the feature/export-metric-parser-interface branch April 6, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants