Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/simplize-methods #4

Merged
merged 5 commits into from Mar 29, 2018
Merged

Conversation

KennethanCeyer
Copy link
Owner

@KennethanCeyer KennethanCeyer commented Mar 29, 2018

changes

  • add valid() function
  • add more unit test codes
  • refactor structures
  • update version to v0.0.5

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #4 into master will increase coverage by 3.41%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   90.01%   93.43%   +3.41%     
==========================================
  Files          25       29       +4     
  Lines         631      670      +39     
  Branches       93       92       -1     
==========================================
+ Hits          568      626      +58     
+ Misses         41       26      -15     
+ Partials       22       18       -4
Impacted Files Coverage Δ
src/builder/builder.error.ts 100% <ø> (ø)
src/tree/simple.tree/type.ts 0% <ø> (ø) ⬆️
src/parser/parser.result.ts 0% <ø> (ø) ⬆️
src/parser/parser.helper.ts 85.71% <ø> (ø) ⬆️
src/builder/builder.helper.ts 90.9% <100%> (ø)
src/packer.ts 100% <100%> (ø)
src/token/token.helper.ts 100% <100%> (+1.81%) ⬆️
src/tool.ts 100% <100%> (ø) ⬆️
src/tree/simple.tree/builder.ts 100% <100%> (+8.77%) ⬆️
src/token/token.helper.base.ts 100% <100%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f0eb4...2b94f70. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 29, 2018

Pull Request Test Coverage Report for Build 133

  • 163 of 167 (97.6%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 94.826%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/token/token.type.helper.ts 11 12 91.67%
src/builder/builder.base.ts 21 24 87.5%
Totals Coverage Status
Change from base Build 123: 2.7%
Covered Lines: 628
Relevant Lines: 654

💛 - Coveralls

@KennethanCeyer KennethanCeyer changed the title WIP: feature/simplize-methods feature/simplize-methods Mar 29, 2018
@KennethanCeyer KennethanCeyer merged commit 091fa2f into master Mar 29, 2018
@KennethanCeyer KennethanCeyer deleted the feature/simplize-methods branch March 29, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants