Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supportsRtl #31

Closed
miladna7 opened this issue Jun 28, 2016 · 6 comments
Closed

supportsRtl #31

miladna7 opened this issue Jun 28, 2016 · 6 comments

Comments

@miladna7
Copy link

miladna7 commented Jun 28, 2016

Hello dear.
is it possible for u to remove or change this line
supportsRtl="true"
(here)
from ur project?
i do not want to support RTL but i cant set it to false, because ur library set it true and for result android studio give me this:

Error:Execution failed for task ':app:processDebugManifest'.
> Manifest merger failed : Attribute application@supportsRtl value=(false) from AndroidManifest.xml:21:9-36
    is also present at [com.github.Kennyc1012:BottomSheet:2.1.1] AndroidManifest.xml:11:18-44 value=(true).
    Suggestion: add 'tools:replace="android:supportsRtl"' to <application> element at AndroidManifest.xml:15:5-62:19 to override. 
@Kennyc1012
Copy link
Owner

Kennyc1012 commented Jun 28, 2016

Did you use the tools:replace="android:supportsRtl" like stated in the output? That should fix the issue.

It should look something like

<application 
tools:replace="android:supportsRtl" ..

@miladna7
Copy link
Author

Yes indeed.
but it give me:

Error:Execution failed for task ':app:processDebugManifest'.
> Manifest merger failed with multiple errors, see logs

and in the log :


6:54:15 PM Executing tasks: [:app:assembleDebug]
6:54:16 PM Gradle build finished with 1 error(s) in 1s 288ms

@Kennyc1012
Copy link
Owner

I got it working with the sample app

 <application
        android:allowBackup="true"
        android:icon="@mipmap/ic_launcher"
        android:label="@string/app_name"
        android:theme="@style/AppTheme"
        android:supportsRtl="false"
        xmlns:tools="http://schemas.android.com/tools"
        tools:replace="android:supportsRtl">
        <activity
            android:name=".MainActivity"
            android:label="@string/app_name" >
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />

                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>
        </activity>
    </application>

Can you paste your application tag?

@miladna7
Copy link
Author

miladna7 commented Jun 28, 2016

So clearly the error are coming from my app.
i keep digging.
Thanks for such a quick response .

  <application
        android:name=".pushService"
        android:allowBackup="true"
        android:icon="@drawable/logo_green_croped"
        android:label="@string/app_name"
        tools:replace="android:supportsRTL"
        android:supportsRtl="false"
        android:theme="@style/AppTheme">

@Kennyc1012
Copy link
Owner

tools:replace="android:supportsRTL"

should be

tools:replace="android:supportsRtl"

Notice the 'l' and 't' are not capitalized in 'Rtl'

@miladna7
Copy link
Author

thank u dear. sorry to take ur time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants