Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split completion functionality into a separate package. #4

Closed
stevengj opened this issue Jul 27, 2013 · 8 comments
Closed

Split completion functionality into a separate package. #4

stevengj opened this issue Jul 27, 2013 · 8 comments

Comments

@stevengj
Copy link

I'm getting Warning: could not import Readline.history_search into REPL when I launch the Julia IPython kernel, which uses REPL.jl for tab completions. The package shouldn't assume that it is actually being used for a REPL or that it is in charge if the history.

Or better yet the completion functionality should be split off into a separate package (so that we don't pull in Terminal and other irrelevant packages REPL needs just to get tab completion, as well as to speed startup time).

cc: @StefanKarpinski

@stevengj
Copy link
Author

stevengj commented Aug 6, 2013

Or should the completion functionality go into Base?

I'm a little confused about how this REPL package relates to the REPL functionality in Base.

@StefanKarpinski
Copy link
Contributor

I have no idea – this is @loladiro's stuff.

@Keno
Copy link
Owner

Keno commented Aug 6, 2013

I plan to eventually replace the REPL implementation in Base with this one - probably in the 0.3, but I can certainly split the completion functionality out before then.

@stevengj
Copy link
Author

stevengj commented Aug 6, 2013

Maybe just merge the completion functionality back into Base for now, then?

@Keno
Copy link
Owner

Keno commented Aug 6, 2013

I'd rather not since it's still very much in flux, but if people feel strongly about this, I can be convinced.

@stevengj
Copy link
Author

stevengj commented Aug 6, 2013

A separate package (in METADATA) would be fine if you think the completion functions aren't ready for Base.

I'm hoping we can clean up the IJulia packaging this week now that it's mostly functional, and the first task is to clean up the dependencies.

@stevengj
Copy link
Author

stevengj commented Aug 7, 2013

All we need are complete_symbol(s) and completions(s,pos); just put them in a module JuliaCompletion or similar and export completions.

I would do it myself, but probably it should live in github/loladiro and you will want to update the REPL package at the same time.

@Keno Keno closed this as completed in 1369399 Aug 8, 2013
@stevengj
Copy link
Author

stevengj commented Aug 8, 2013

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants