-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split completion functionality into a separate package. #4
Comments
Or should the completion functionality go into Base? I'm a little confused about how this REPL package relates to the REPL functionality in Base. |
I have no idea – this is @loladiro's stuff. |
I plan to eventually replace the REPL implementation in Base with this one - probably in the 0.3, but I can certainly split the completion functionality out before then. |
Maybe just merge the completion functionality back into Base for now, then? |
I'd rather not since it's still very much in flux, but if people feel strongly about this, I can be convinced. |
A separate package (in METADATA) would be fine if you think the completion functions aren't ready for Base. I'm hoping we can clean up the IJulia packaging this week now that it's mostly functional, and the first task is to clean up the dependencies. |
All we need are I would do it myself, but probably it should live in |
Awesome, thanks! |
I'm getting
Warning: could not import Readline.history_search into REPL
when I launch the Julia IPython kernel, which uses REPL.jl for tab completions. The package shouldn't assume that it is actually being used for a REPL or that it is in charge if the history.Or better yet the completion functionality should be split off into a separate package (so that we don't pull in Terminal and other irrelevant packages REPL needs just to get tab completion, as well as to speed startup time).
cc: @StefanKarpinski
The text was updated successfully, but these errors were encountered: