Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compatible modules for Kentico 10 #123

Closed
petrsvihlik opened this issue Sep 27, 2016 · 6 comments
Closed

Enable compatible modules for Kentico 10 #123

petrsvihlik opened this issue Sep 27, 2016 · 6 comments
Milestone

Comments

@petrsvihlik
Copy link
Contributor

petrsvihlik commented Sep 27, 2016

  • test modules against K10
  • enable those that work
  • adjust those that don't (or create new issues if fixes require more effort)

pseudo code of what needs to be done:

clone the repository
for each (module in https://github.com/Kentico/KInspector/tree/master/KInspector.Modules)
{
  add new Version("10.0") to SupportedVersions array
  if(module returns correct data)
  {
    leave the supported version in
  }
  else
  {
    try
    {
      fix the module while not breaking it for older versions
    }
    catch
    {
       remove "10" from the supported versions array
       create new issues in this repository if the fix requires more effort
    }
  }
}
commit the changes

@petrsvihlik petrsvihlik added this to the 3.5 milestone Sep 27, 2016
@ChristopherJennings ChristopherJennings modified the milestones: 3.5, 3.6 Dec 15, 2016
@ileshmistry
Copy link
Contributor

Hello

I was just wondering when we might expect this to be V10 compatible? I am trying to look at a few new K10 sites to make them KInspector-fied, but noticed we couldn't use it fully.

Thanks
Ilesh

@petrsvihlik
Copy link
Contributor Author

Hi @ileshmistry ,
as soon as someone picks up the issue.
@ChristopherJennings any plans on assigning it to someone internal?
@ileshmistry you or someone from MMT can pick it up if you want. I can explain what needs to be done. Actually, I'll update the description of this issue right away.

@ileshmistry
Copy link
Contributor

Thanks @petrsvihlik if you can let us know what might need doing, we can go from there :)

@ChristopherJennings
Copy link
Contributor

@petrsvihlik & @ileshmistry,
Unfortunately, there isn't really any bandwidth right now for someone internal to take this on unless they do it on their own time. @petrsvihlik has updated the description with a good summary of what needs doing. @ileshmistry, Please leave a comment here if you or someone on your team plans to tackle this so we don't accidentally end up with duplicated effort.

@ileshmistry
Copy link
Contributor

@petrsvihlik @ChristopherJennings giving this a go and will tackle each module at a time

@petrsvihlik
Copy link
Contributor Author

@ileshmistry highly appreciated!

ChristopherJennings pushed a commit that referenced this issue Jan 19, 2017
Enable the following modules:
* Attachments By Size module
* Duplicate Page Aliases module
* Number Of Aliases module
* Page Type Assigned module
* Site Templates module
* Tree Node Children module
* Web Parts In Transformations module
* Workflow Consistency module
* Application Restarts module
* Event Log Errors module
* Event Log Size module
* Page Not Founds module
* Big Tables module
* Database Consistency Check module
* Debug Check module
* Documents Consistency Issues module
* Media Library Azure Limit module
* Page Type Fields Data Type Mismatch module
* Scheduled Tasks module
* Screenshotter module
* Settings module
* Task Processing Issues module
* OM Contact Group With Manual Macro module
* OM Inactive Contacts Deletion module
* OM Tables Size module
* Click Jacking module
* Password Policy module
* Password Policy module
* Security App Settings module
* Security Settings module
* SSL In Administration module
* Transformation Analyser module
* Users With Empty Passwords module
* Users With Plaintext Passwords module
* Web Part Analyser module
* Expired Tokens module

Update to password policy test to include the V10 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants