New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a module to detect Duplicate Page Aliases #59

Merged
merged 2 commits into from Dec 29, 2015

Conversation

Projects
None yet
3 participants
@MikeFoden
Contributor

MikeFoden commented Dec 21, 2015

Fixes #2

@petrsvihlik

This comment has been minimized.

Member

petrsvihlik commented Dec 27, 2015

Thanks for the contribution, Mike! 👍 The code looks good. I found just one little issue related to cultures:

  • when culture of an alias is set to "All Cultures" (in DB represented as AliasCulture='') it should collide with other aliases no matter what culture they have set.

When this is fixed we can merge your pull request.

'All Cultures' fix.
Added in a fix to account for when an alias is set up for 'All
Cultures'.
@MikeFoden

This comment has been minimized.

Contributor

MikeFoden commented Dec 29, 2015

I have updated this to now include 'All Cultures' as it should have always been.

I also updated the message I created for when an AliasURLPath is being used as a NodeAliasPath for a Tree Node to show which Node has it as an Alias Path.

petrsvihlik added a commit that referenced this pull request Dec 29, 2015

Merge pull request #59 from MikeFoden/Duplicate-Page-Alias-Module
Created a module to detect Duplicate Page Aliases

@petrsvihlik petrsvihlik merged commit 8d4fe5a into Kentico:master Dec 29, 2015

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@petrsvihlik

This comment has been minimized.

Member

petrsvihlik commented Dec 29, 2015

Works great!

@MikeFoden MikeFoden deleted the MikeFoden:Duplicate-Page-Alias-Module branch Dec 29, 2015

@ondrejsevcik ondrejsevcik modified the milestone: 3.0 Mar 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment