Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded assets in app #17

Closed
CollierCZ opened this issue Oct 9, 2018 · 6 comments
Closed

Hardcoded assets in app #17

CollierCZ opened this issue Oct 9, 2018 · 6 comments
Assignees
Labels
bug Something isn't working groomed The issue has been groomed and should be in a good shape. hacktoberfest help wanted Extra attention is needed up-for-grabs

Comments

@CollierCZ
Copy link
Contributor

CollierCZ commented Oct 9, 2018

Motivation

Currently, it's unclear at first what content is hardcoded in the app and what is drawn from Kentico Kontent. For example, the Hero unit on the homepage is not drawn from Kentico Kontent. So it's possible to run the app and get confused when changing the Hero unit in Kentico Kontent doesn't change the content in the app.

Proposed solution

  • create an account in Kentico Kontent and let it generate a sample project for you
  • search for jpg in this repo
  • replace all hardcoded assets with ones from Kentico Kontent.
    -- use the JavaScript SDK to retrieve the assets using their codenames
    -- see the docs for more details about how to work with Kentico Kontent API
  • remove replaced assets from this repository

Additional context

@petrsvihlik petrsvihlik added bug Something isn't working help wanted Extra attention is needed up-for-grabs groomed The issue has been groomed and should be in a good shape. hacktoberfest labels Oct 9, 2018
@petrsvihlik petrsvihlik changed the title Hardcoded features in app Hardcoded assets in app Oct 9, 2018
@Lawrence4code
Copy link

I would like to work on this, please.

@ChristopherJennings
Copy link

Go for it!

Looking forward to the PR. Let us know if you have any questions.

@Lawrence4code
Copy link

@ChristopherJennings thanks for your response and info above.
The link the JavaScript is broken, could you please guide to the resource where I can retrieve the images.
Thanks in advance :)

@CollierCZ
Copy link
Contributor Author

I updated the links in the description so they should work. And the implementation in the React app should help point the right way: kontent-ai/sample-app-react@f0ba629#diff-43359e39b6f36d641fc3f393f930d9de

@ChristopherJennings
Copy link

The resources @CollierCZ pointed you to should help. Basically, the URL for the image should come from the API response as seen in the diff linked above.

@Lawrence4code
Copy link

Thanks for the guidance, I started working on it.

@Simply007 Simply007 mentioned this issue Jun 26, 2020
5 tasks
@Simply007 Simply007 self-assigned this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working groomed The issue has been groomed and should be in a good shape. hacktoberfest help wanted Extra attention is needed up-for-grabs
Projects
None yet
Development

No branches or pull requests

5 participants