Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/60 #61

Merged
merged 7 commits into from
Jul 3, 2020
Merged

Fix/60 #61

merged 7 commits into from
Jul 3, 2020

Conversation

Simply007
Copy link
Contributor

@Simply007 Simply007 commented Jun 26, 2020

Motivation

Fixes #60

Also, remove one hardcoded asset from #17

  • Add information about data sources to the readme and inform about the in the info message when user selects the project.
  • Rebuild Banner component to be dynamic and displays the first hero unit.
    • Also prepared infrastructure for A/B testing (all hero unit banners are loaded) - so just a logic that selects which banner to use based i.d. query string, etc could be used

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Simply007 Simply007 requested a review from makma June 26, 2020 09:19
@Simply007 Simply007 self-assigned this Jun 26, 2020
Copy link

@makma makma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works as expected, the readme is didactic. I've introduced one more change since it seems the original vue-i18n-loader has been deleted from the npm registry. I've replaced it with @intlify/vue-i18n-loader. Other changes look good.

@Simply007 Simply007 merged commit cdf2689 into master Jul 3, 2020
@Simply007 Simply007 deleted the fix/60 branch July 3, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the projects dynamic parts
2 participants