Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP pages Canonical URL macros not resolving #39

Open
bhuvanavramana opened this issue Nov 18, 2019 · 1 comment
Open

AMP pages Canonical URL macros not resolving #39

bhuvanavramana opened this issue Nov 18, 2019 · 1 comment
Assignees

Comments

@bhuvanavramana
Copy link

bhuvanavramana commented Nov 18, 2019

We have implemented the AMP Module in our site based on the below reference link and our site running on kentico 10 version and the Nuget package version we used for AMP module is Kentico.AcceleratedMobilePages/1.0.3.

Ref: https://devnet.kentico.com/articles/google-amping-the-kentico-advantage-site

We have an issue in our site while browsing the page we are getting wrong URL as canonical URL.
We have given custom URL pattern to our page.
In that custom URL we given a macros like "/amp/{sectionname}/{mm}/{dd}/{yy}/{title}", so the canonical URL displaying

the same path instead of page URL.
Below are the steps to reproduce the issue on live site.

Kindly help me to get the correct canonical url display or to remove the canonical URL link.
custom url path

@fvolner
Copy link

fvolner commented Dec 2, 2019

The issue occurs because of the implementation of the GetDocumentPath method that takes the DocumentUrlPath property, which does not resolve the wildcard.

You can check a quick fix I did in my forked repository and apply it to your code to see if it resolves your issue.

After a proper review, those changes will be merged into this repository.

@petrsvihlik petrsvihlik assigned ivann14 and fvolner and unassigned ivann14 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants