Add tests #5
Add tests #5
Conversation
tests/Tests/IAlgoliaClientTests.cs
Outdated
|
|
||
| namespace Kentico.Xperience.Algolia.Test | ||
| { | ||
| internal class IAlgoliaClientTests |
There was a problem hiding this comment.
Test is testing class not interface, rename the class.
Add tests for GetStatistics(...) method as well, check that cache is used and underlying search client is used.
Add tests for Rebuild(...) method as well, check that underlying search index method is called with expected parameters.
There was a problem hiding this comment.
Added GetStatistics test in 7d647c6, please let me know if it's correct.
For Rebuild, because it uses DocumentQuery I don't believe I can test that unless we use isolated integration tests, correct?
There was a problem hiding this comment.
Unfortunately I don't know whether is possible to disconnect MultiDocumentQuery from database. Someone from CM1 team will give you a hint. If it's not possible introduce isolated integration test.
There was a problem hiding this comment.
I added tests in 887d7be by replacing MultiDocumentQuery with IPageRetriever, let me know if it looks okay
| await algoliaClient.Rebuild(nameof(ArticleEnSearchModel), CancellationToken.None); | ||
|
|
||
| await mockPageRetriever.Received(1).RetrieveMultipleAsync(Arg.Any<Action<MultiDocumentQuery>>()); | ||
| await mockIndexService.Received(1).InitializeIndex(nameof(ArticleEnSearchModel), Arg.Any<CancellationToken>()); |
There was a problem hiding this comment.
Check that cancellation token is passed to inner call. Amend this also in another tests, namely:
- GetStatistics_CallsMethods
- DeleteRecords_ValidIndex_ReturnsProcessedCount
- UpsertRecords_ValidIndex_ReturnsProcessedCount
- CrawlUrls_HttpClientReceivesParameters
- GetCrawler_CallsMethods
- ProcessAlgoliaTasks_ValidTasks_ProcessesTasks
- ProcessCrawlerTasks_ValidTasks_ReturnsProcessedCount
There was a problem hiding this comment.
@kentico-jaroslavn I added a missing CancellationToken usage in 8ca352a but I'm unsure what else the tests should check for. The tests are already checking Arg.Any<CancellationToken>() which ensures that the token is non-null
There was a problem hiding this comment.
Test should check that the same instance of cancellation token is passed to underlying method.
There was a problem hiding this comment.
@kentico-jaroslavn I added CancellationToken tests in 7db1794. But, there are 2 tests that I had an issue with: GetCrawler_CallsMethods and CrawlUrls_HttpClientReceivesParameters. It seems that when MockHttpMessageHandler.SendAsync() is called, it receives a different token, probably set from the HttpClient. I cannot find a way to ensure that it receives the same token that is passed through other methods, do you have any advice?
| await algoliaClient.Rebuild(nameof(ArticleEnSearchModel), CancellationToken.None); | ||
|
|
||
| await mockPageRetriever.Received(1).RetrieveMultipleAsync(Arg.Any<Action<MultiDocumentQuery>>()); | ||
| await mockIndexService.Received(1).InitializeIndex(nameof(ArticleEnSearchModel), Arg.Any<CancellationToken>()); |
There was a problem hiding this comment.
Test should check that the same instance of cancellation token is passed to underlying method.
| @@ -32,10 +33,13 @@ public void HandleEvent(TreeNode node, string eventName) | |||
| var taskType = GetTaskType(node, eventName); | |||
|
|
|||
| // Check crawlers | |||
| foreach (var crawlerId in IndexStore.Instance.GetAllCrawlers()) | |||
| if (node.Site.SiteStatus == SiteStatusEnum.Running) | |||
There was a problem hiding this comment.
Indexing the structured content when site is stopped is intended, right?
There was a problem hiding this comment.
Yes, I believe that is the desired behavior for structured content. If the site is stopped for emergency fixes or large page updates, when it is started again the index will already be up-to-date. For crawlers that's unfortunately not possible since the pages can't be crawled while offline.
Motivation
Adds unit tests to the integration
Checklist