Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature v28 #24

Merged
merged 63 commits into from
Jan 12, 2024
Merged

Feature v28 #24

merged 63 commits into from
Jan 12, 2024

Conversation

bkapustik
Copy link
Collaborator

No description provided.

@bkapustik
Copy link
Collaborator Author

image

Questions about the numbered items in the screenshot

1 - Path

  1. Do % characters work as wildcards in the path value? Is there a difference between /blog/posts/% and /blog/posts for a path?
  2. It's up to users to make sure the paths exist in the channel when they switch the channel below?
  3. Can we change "Path" to "Included path"?

2 - Content type list

  1. Is this supposed to be a list of all content types in the solution or the currently included content types for the path?
  2. Can this list be displayed in a way that is easier to read? Maybe a grid or vertical list?
  3. Should "Included Content Types(" be changed to "Available Content Types"? "Included Content Types" is only accurate when the textarea below is empty, correct?
  4. Can we include the "Separate by new line" instructions for the textarea below the textarea but above the "Save Path" button?

3 - Content type input

  1. Can we give this textarea a separate label to make it more readable and accessible? I don't think the list of content types should be in the label text of a form field - this is confusing.
  2. If my BlogPostPage references a BlogPostContent content type and updates to BlogPostContent items should cause a reindex of BlogPostPage items, do I need to include KenticoCommunity.BlogPostContent in the list? If so, how do I then prevent that content type from being indexed itself. If not, can I limit which content types trigger FindItemsToReindex when they are updated? I tested this behavior and see that FindItemsToReindex(IndexedContentItemModel changedItem) is called for every change of a reusable content item, so it's up to the developer to check the items when the method is called.

I'm thinking something like this

image

This is probably more appropriate for a later improvement, but can the list of included content types for each path be included in the table of paths at the top of this form?

1.1 They do not
1.2 It is
1.3 changed

2.1 list of all webpage item types in the solution

@seangwright seangwright merged commit 2bf70a7 into main Jan 12, 2024
2 checks passed
@seangwright seangwright deleted the feature_v28 branch January 17, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants