Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): remove json files from nuget package content folders #18

Merged
merged 12 commits into from
May 8, 2024

Conversation

bkapustik
Copy link
Collaborator

Motivation

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

<Content Remove="Admin/Client/*.json" />
<Content Remove="Admin/FrontEnd/*.json" />
<Content Remove="Admin/*.json" />
<Content Remove="../Kentico.Xperience.TagManager/*.json"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation.

@seangwright
Copy link
Member

seangwright commented May 7, 2024

@michalJakubis I resolved a couple outstanding issues with the repo and validated that the NuGet package no longer contains the extra files (it still had 1 extra, unused JS file when I initially tested).

@bkapustik I noticed the nuget.config was changed in commit b8fde0a271eb1f07291f03fdc30deab6d1b7e587. The nuget.config is intentionally setup to allow for local testing of NuGet packages which helps us make sure the package is built correctly and includes all the required files.

However, I also saw there had been a line that was uncommented that should have been commented out, and it caused non-package local development to not work for you.

I fixed this and I also improved the documentation for local NuGet package testing.

@seangwright seangwright merged commit f1cbb7f into main May 8, 2024
1 check passed
@seangwright seangwright deleted the fix/remove-redundand-files-in-nuget branch May 8, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants