-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom contact field/fb #51
Open
dominikag2
wants to merge
27
commits into
finished
Choose a base branch
from
CustomContactField/FB
base: finished
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,011
−594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f0533ce)
The contact edit page can not be altered by simply defining a new field in Modules app. Will have to use extenders. Not sure how to manipulate with properties yet in this specific case.
…, set up permissions
…ct with wrong name
…how Is member Yes/No in the form, instead of the string MemberId
+ Added custom fields into Contact edit form to ensure they are available for contact groups conditions + Created a sample Espresso lovers contact group
…ctory.Build.props, replace with "training guides" and update links
xmerta00
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, the code looks great. You may add error handling in the GetContactMemberId method (if GetInfoObject() or Get() fails) and a few comments, but otherwise, I see no issues with the code.
…n be consolidated
Merge Custom Module UI changes into Custom Form Field branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom fields on Contact profile example. GH-47