-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load.project issues #76
Conversation
Converted from issue using |
… (with a warning).
Ready for review. |
for (helper.script in dir('lib')) | ||
helpers <- dir('lib', pattern = '[.][rR]$') | ||
deprecated.files <- intersect( | ||
helpers, c('boot.R', 'load_data.R', 'load_libraries.R', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we define deprecated files in an external file. Then as files are deprecated in the future won't need to hunt for them in source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we need it? An external file adds an extra level of complexity, and it might be more difficult to find it. It's only a few files, after all, and the list is not likely to become much larger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it might be a bit of YAGNI, especially if the file list might not change. Perhaps pull it into a function? Can probably be deferred until we need to update the list.
Do you think we need 0570eb7 (ad-hoc change of configuration) if we can have multiple config files? |
I think it should be kept. One of the annoyances of rails is having to create a new configuration file just to launch with a simple change. I like that this commit can let me override config variables for a quick one off. Multiple config files are then useful for settings I use frequently. |
Addressed all issues, will merge later today. Thanks for the review. |
$
to access config options$
to accessmy.project.info
config
: Extract to functionon
/off
should be converted tological
pattern
parameter indir()
require.package
Extract functions, one per stepavoid duplication of(Avoid duplication of global.dcf #79)global.dcf