Fix/avoid sagify module import clash #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilazakis
approved these changes
Jan 11, 2020
| '.gitkeep' | ||
| ] | ||
| }, | ||
| install_requires=[ | ||
| 'boto3==1.9.220', | ||
| 'boto3', |
There was a problem hiding this comment.
Any specific reason for removing the pinned version of boto3 in particular?
There was a problem hiding this comment.
Hey @ilazakis , users have to use awscli that depends on boto3. Each end user has a different version of awscli and by specifying a specific boto3 version may cause conflict.
ilazakis
reviewed
Jan 24, 2020
| @@ -1,59 +1,59 @@ | |||
| from collections import namedtuple | |||
There was a problem hiding this comment.
@pm3310 Missed this when reviewing. Did these tests need to be disabled? Can we re-enable them? Also, looks like the 0.20.0 merge failed on Python3.
There was a problem hiding this comment.
@ilazakis good catch man! My bad :-( I'll create a new PR for this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
sagify initautomatically creates a module calledsagify. However, we have specific methods from sagify library such asfrom sagify.api.hyperparameter_tuning import log_metric. Python interpreter gets confused if it tries to loadfrom sagify.api.hyperparameter_tuning import log_metric. It think it should search under the automatically created modulesagify, then, it cannot find and raises an error. This PR fixes this issue.