Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add possibility to convert time during ascii and csv conversion #76
@@ Coverage Diff @@ ## master #76 +/- ## ========================================== + Coverage 18.84% 19.22% +0.37% ========================================== Files 53 53 Lines 9466 9510 +44 ========================================== + Hits 1784 1828 +44 Misses 7682 7682
referenced this pull request
Aug 2, 2017
We are going to want to make it more clear in the docstring that these times are for "Solar System Barycenter" (cf. archive manual page 17). This is important because it is common to assume that e.g. an ISO timestamp is Earth-centered, but Kepler gives the time a photon would arrive in the Solar System Barycenter to take Earth's ever-changing position in the Solar System out of the equation.
I also wonder if we can add a specific unit-test to verify the conversion, e.g. we could check whether header keywords TSTART and DATE-OBS are equal if converted using the method used here.
(I'm being nitpicky because it's so easy to get time systems wrong.)