Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear attack phase & Linear decay/release phases setting logic inverted? #256

Closed
minelolpride opened this issue Jun 22, 2023 · 2 comments
Closed
Labels
Bug Issue that affects the stability of the driver.

Comments

@minelolpride
Copy link

Problem
In 14.6 CR58 you added support for linear attack phase & linear decay/release phases to be used on SF2 soundfonts, leaving the options disabled by default. The control logic for both of the settings are inverted. (so it's off when you go to "enable" it)

Found by checking the audio during playback against the audio produces from 14.6 CR55 (the previous pre-release). This occurs as of 14.7.1.

Steps to reproduce

  1. Install OM 14.6.0.58 or later
  2. Load a soundfont with little release time such as this one
  3. Load any MIDI with the linear phase settings disabled. (as they are by default)
  4. Find out that the audio is slightly different. (the notes stick around for much longer than in previous versions)
  5. Enable the linear phase settings & reload the MIDI
  6. Observe playback audio parallel to that from previous versions.

Expected behavior
Linear phases should not be active when the relevant settings are disabled.

Screenshots/Videos
(No video at this time.)

Environment

  • Operating system: Windows 10
  • CPU: Ryzen 7 5800X3D
  • RAM: 64GB DDR4-2666 (OC: DDR4-2800)
  • MIDI application: Piano From Above (Version 1.1.0)
  • Version of the driver: 14.7.1

Additional context
I've somehow gaslit myself into not noticing this sooner, but listening to audio from a converter & later listening to a MIDI with an old familiar soundfont alerted me to this being a thing.

@KaleidonKep99 KaleidonKep99 added the Bug Issue that affects the stability of the driver. label Jun 22, 2023
@KaleidonKep99
Copy link
Collaborator

Will be fixed in 14.8.

@KaleidonKep99
Copy link
Collaborator

Fixed in 14.8+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issue that affects the stability of the driver.
Projects
None yet
Development

No branches or pull requests

2 participants