ReadStringNullTerminated optimization

Kermalis · Sep 8, 2020 · 6975508 · 6975508
1 parent dddb7d2
commit 6975508
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/Source/EndianBinaryReader.cs b/Source/EndianBinaryReader.cs
@@ -265,13 +265,17 @@ public string ReadStringNullTerminated(long offset)
         }
         public string ReadStringNullTerminated(EncodingType encodingType)
         {
-            string text = "";
-            do
+            string text = string.Empty;
+            while (true)
             {
-                text += ReadChar(encodingType);
+                char c = ReadChar(encodingType);
+                if (c == '\0')
+                {
+                    break;
+                }
+                text += c;
             }
-            while (!text.EndsWith("\0", StringComparison.Ordinal));
-            return text.Remove(text.Length - 1);
+            return text;
         }
         public string ReadStringNullTerminated(EncodingType encodingType, long offset)
         {