Makefile refinements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipawel
reviewed
Aug 11, 2020
| @@ -53,6 +53,18 @@ The `make` command generates the `kernel64.bin` multiboot-compatible ELF file, t | |||
| The `make iso` command takes the `kernel64.bin`, places it in `grub/boot/` directory hierarchy and generates a `boot.iso` | |||
| out of the `grub/` (using `grub/boot/grub/grub.cfg` as a default GRUB config). | |||
|
|
|||
| #### Fedora | |||
There was a problem hiding this comment.
Does it make sense to detect current distro via /etc/os-release and automagically include corresponding Makefile.local?
There was a problem hiding this comment.
That would be the next step. With this PR we create the basic infrastructure for custom Make configs. We can later follow up with autodetecting environments.
Add a mechanism to the Makefile that uses an optional `Makeconf.local` file to override variables set in the main Makefile. This mechanism along with the changes allows non-standard overrides for all tools used in the Make targets. Also add a README section on how this enables building and running KTF on Fedora. Signed-off-by: Bjoern Doebel <bjoern.doebel@gmail.com>
All the run-style targets depend on a valid ISO file being created, so let's make that explicit. Signed-off-by: Bjoern Doebel <bjoern.doebel@gmail.com> fixup! Makefile: fix dependencies
wipawel
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Closes #27
Description of changes:
Makefile tweaks to make tooling more configurable and fix targets that depend on ISO generation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.