Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: Unable to compile on windows #1

Closed
numToStr opened this issue Jun 11, 2021 · 11 comments
Closed

Re: Unable to compile on windows #1

numToStr opened this issue Jun 11, 2021 · 11 comments

Comments

@numToStr
Copy link

Originally posted here meilisearch/heed#107

Currently, https://github.com/Kerollmops/heed with mdbx backend is not compiling on windows. Also, @erthink pointed out that the issue might be in the bindings.

I am still new to rust but I am willing to help ✌🏻

@erthink
Copy link

erthink commented Jun 11, 2021

@numToStr, You might want to ask @vorot93 about the availability/readiness of another libmdbx-to-Rust binding that (AFAIK) is being developed for Erigon project.

@numToStr
Copy link
Author

numToStr commented Jun 11, 2021

@erthink I think, I found it https://github.com/vorot93/mdbx-rs

Edit: but sadly it is not yet published.

@Kerollmops
Copy link
Collaborator

I am open to pull requests, as I am not really using mdbx-rs for my own project, I could also give the ownership to anyone who want it.

@erthink
Copy link

erthink commented Jun 12, 2021

@vorot93, I suggest you think about taking this project to yourself.
This seems reasonable if you expect me to solve erthink/libmdbx#200 and erthink/libmdbx#203.

@vorot93
Copy link
Owner

vorot93 commented Jun 13, 2021

@Kerollmops could you please transfer this repo to rust-ethereum then and give me the rights to publish mdbx-sys to crates.io?

@Kerollmops
Copy link
Collaborator

Kerollmops commented Jun 13, 2021

I can't transfer it to the rust-ethereum organization directly, I don't have the right to create a public repository. I can transfer it to you if you have the right to create public repositories in the rust-ethereum organization, this way you can transfer it by yourself.

On the other hand, I sent you an invite to publish new releases of mdbx-sys on crates.io.

@vorot93
Copy link
Owner

vorot93 commented Jun 13, 2021

@Kerollmops yep, that would work too

@sauliusgrigaitis
Copy link

Great work on mdbx-rs!

We consider replacing RocksDB with MDBX in Grandine. One of the criteria is the support of the all three Linux, macOS and Windows. Could you let me know when Windows support is planned? Or this is a very low priority?

@vorot93
Copy link
Owner

vorot93 commented Aug 6, 2021

@sauliusgrigaitis Windows is a low-priority target to me. Given that, the error looks trivial to fix, so let's see what can be done.

@iquiw
Copy link

iquiw commented Aug 21, 2021

I could build an app that depends on mdbx-sys through heed on Windows by using the build script.

fn main() {
    println!("cargo:rustc-link-lib=dylib=ntdll");
    println!("cargo:rustc-link-lib=dylib=user32");
}

@gcxfd gcxfd mentioned this issue Nov 20, 2021
@vorot93
Copy link
Owner

vorot93 commented Nov 27, 2021

Should work on Windows now

@vorot93 vorot93 closed this as completed Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants