Ryan iter 1 #24
Ryan iter 1 #24
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -1,4 +1,4 @@ | |||
| module TestModule | |||
| module RepositoryModule | |||
There was a problem hiding this comment.
Style/Documentation: Missing top-level module documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
| # | ||
| # end | ||
| def golden_items | ||
|
|
There was a problem hiding this comment.
Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
| # def golden_items | ||
| # | ||
| # end | ||
| def golden_items |
There was a problem hiding this comment.
Style/EmptyMethod: Put empty method definitions on a single line.
|
|
||
| def merchants_with_high_item_count | ||
| threshold = average_items_per_merchant + average_items_per_merchant_standard_deviation | ||
| @merchants.all.find_all { |merchant| items_per_merchant(merchant.id) > threshold } |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [86/80]
| # | ||
|
|
||
| def merchants_with_high_item_count | ||
| threshold = average_items_per_merchant + average_items_per_merchant_standard_deviation |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [90/80]
| # xit '' do | ||
| # end | ||
|
|
There was a problem hiding this comment.
Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.
| xit '#merchants_with_high_item_count can determine which merchants sell the highest number of items' do | ||
|
|
||
| it '#merchants_with_high_item_count can determine which merchants sell the highest number of items' do |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [106/80]
| it '#average_items_per_merchant_standard_deviation can determine standard deviation on average items per merchant' do | ||
| expect(sales_analyst.average_items_per_merchant_standard_deviation).to eq(1.0) | ||
| expect(sales_analyst.average_items_per_merchant_standard_deviation).to eq(0.71) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [85/80]
No description provided.