Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite decimals that are not actually decimals to numbers #140

Merged
merged 3 commits into from
Apr 1, 2023

Conversation

KevinDaGame
Copy link
Owner

No description provided.

@Lennart99
Copy link
Collaborator

I will do a full review later (on phone now), but just one comment: changing the text of messages in the lang file won't actually change the text in servers that already have that message in the file (so that people can change the messages on their end). We will need to think about how to fix this., maybe a config option to overwrite existing messages (default true).

@KevinDaGame
Copy link
Owner Author

KevinDaGame commented Mar 30, 2023

I will do a full review later (on phone now), but just one comment: changing the text of messages in the lang file won't actually change the text in servers that already have that message in the file (so that people can change the messages on their end). We will need to think about how to fix this., maybe a config option to overwrite existing messages (default true).

I'm aware that it won't affect existing installs. That's fine. I think that we should make a migration setting that moves the old config (and lang files) to a backup folder so they are recoverable in any case, which should fix the existing server problem

@KevinDaGame KevinDaGame merged commit 2b5fd54 into develop Apr 1, 2023
@KevinDaGame KevinDaGame deleted the Feat/decimaltonumber branch April 1, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants