This repository has been archived by the owner on Sep 30, 2022. It is now read-only.
refactor: migrate to nodejs action #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinDeJong-TomTom
force-pushed
the
feat/javascript-action
branch
4 times, most recently
from
f32656c
to
74c3c6b
Compare
This change will have the following impact: * Interactions with GitHub are no longer required by Commisery * Performance improvement as we no longer require a Docker image * Addition of a Summary page * No longer scan the title of the Pull Request
KevinDeJong-TomTom
force-pushed
the
feat/javascript-action
branch
from
c7f0f46
to
fc3d030
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move towards the utilisation of typescript (NodeJS) for the execution of Commisery instead of relying on Docker.
This should significantly reduce the execution time for a single scan and removes the need for GitHub specific behaviour in the external tool
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.