Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9 - DisabledHandlers setting is ignored? #231

Closed
JoseMarcenaro opened this issue May 3, 2021 · 5 comments
Closed

v9 - DisabledHandlers setting is ignored? #231

JoseMarcenaro opened this issue May 3, 2021 · 5 comments
Labels
9.x NETCORE Something we need to look at on uSync .net core edition v9/beta-002 beta 002 - issues for uSync on netcore

Comments

@JoseMarcenaro
Copy link
Contributor

JoseMarcenaro commented May 3, 2021

I'm trying to disable the "contentHandler" and "mediaHandler" to emulate the v8 behavior (without uSync.Content)
Based on this documentation https://docs.jumoo.co.uk/uSync/v9/settings/ I've added those handlers aliases in the DisbledHandlers array, but it looks like they are not properly read by the Configuration getter

image

Note that the other setting (HandlerDefaults.UseFlatStructure) is properly read and used.

Am I doing something wrong?
Thanks in advance

@JoseMarcenaro
Copy link
Contributor Author

JoseMarcenaro commented May 3, 2021

I've found it!
It looks like .Net core appSettings loader is not so great at deserializing lists - in fact, that wasn't working at all some time ago.

The way to make it work is to type the property as an array:

image

And that reads the two strings into the DisabledHandlers array.
@KevinJump let me know if you want me to send a PR for this or you just fix it. Thx.

KevinJump added a commit that referenced this issue May 4, 2021
@KevinJump
Copy link
Owner

thanks - fixed it - we are going to try and find easier way to turn content/on off. maybe something that turns the groups on/off might do it.

@KevinJump KevinJump added 9.x NETCORE Something we need to look at on uSync .net core edition v9/beta-002 beta 002 - issues for uSync on netcore labels May 4, 2021
@chris-evansnz
Copy link

thanks @JoseMarcenaro and @KevinJump I was looking for this exact config to turn off content and media handlers - am currently using beta001

Is beta002 released or will we need to run a nightly build to get this feature? where do we find the nightlies?

@KevinJump
Copy link
Owner

KevinJump commented May 11, 2021

Hi,

we didn't really have a set timeline for beta002 - other than matching what ever Umbraco's release schedule is - we might release something pre-codegarden (but i expect Umbraco will too)

but the nightlies are on this feed:

dotnet nuget add source https://pkgs.dev.azure.com/jumoo/Public/_packaging/nightly/nuget/v3/index.json

for handler disabling you might also want to checkout the changes to ExportOnSave setting in the nightly
#232

this means you can 'just' turn off content/media saving by setting the ExportOnSave setting to 'Settings' and while the handlers will still be there is you want to export from the back office saving/editing content will not write anything to disk.

@chris-evansnz
Copy link

Thanks for the info! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.x NETCORE Something we need to look at on uSync .net core edition v9/beta-002 beta 002 - issues for uSync on netcore
Projects
None yet
Development

No branches or pull requests

3 participants