Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatable strings inside DocTypeGridEditors are not deserialized correcltly. #323

Closed
KevinJump opened this issue Jan 6, 2022 · 2 comments
Assignees
Labels
8.x FRAMEWORK 9.x NETCORE Something we need to look at on uSync .net core edition

Comments

@KevinJump
Copy link
Owner

If you have a Repeatable String property inside a document type that you are using inside a DocTypeGrid Editor then the values are not created when you import to a new site.

this is because the default behavior of the doctypegrid editor mapper is to escape the json values of any nested json properties (this is how we do it for nestedcontent, content blocks etc) however for the doctype grid editor we should not do this :(

@KevinJump KevinJump self-assigned this Jan 6, 2022
@KevinJump KevinJump added 9.x NETCORE Something we need to look at on uSync .net core edition 8.x FRAMEWORK labels Jan 6, 2022
@KevinJump
Copy link
Owner Author

Fix for this, is to not encode - but we also need to ensure that any nested nested values are not encoded,

so for example if there is a nested content block inside the doctypegrid editor and that contains yet more nested json values, we need to expand them but only when in the dcotype grid editor and not when we are inside other editors.

@KevinJump
Copy link
Owner Author

re-open Also need fix for v8 branch

KevinJump added a commit that referenced this issue Jan 6, 2022
KevinJump added a commit that referenced this issue Jan 6, 2022
@KevinJump KevinJump changed the title Repeatable strings inside DocTypeGridEditors are not serialized correcltly. Repeatable strings inside DocTypeGridEditors are not deserialized correcltly. Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x FRAMEWORK 9.x NETCORE Something we need to look at on uSync .net core edition
Projects
None yet
Development

No branches or pull requests

1 participant