Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inhertited doctypes loose and then regain their parent between syncs #372

Closed
KevinJump opened this issue Mar 22, 2022 · 1 comment · Fixed by #373
Closed

Inhertited doctypes loose and then regain their parent between syncs #372

KevinJump opened this issue Mar 22, 2022 · 1 comment · Fixed by #373
Assignees
@KevinJump
Labels
v9/9.3.0
Milestone
9.3.0 - Single pa...

Comments

@KevinJump
Copy link
Owner

When syncing a doctype with a parent item (inherited) the parent will be lost and then regained between syncs.

eg.
first sync -> parent will be removed
second sync -> parent is added back

*this doesn't effect the properties on the doctype as they are kept though the composition settings. *

(original report : Jumoo/uSync.Complete.Issues#169 )
@KevinJump KevinJump self-assigned this Mar 22, 2022
@KevinJump KevinJump mentioned this issue Mar 22, 2022
Merged
@KevinJump
Copy link
Owner Author

Fixed for next patch release.

@KevinJump KevinJump mentioned this issue Mar 22, 2022
Closed
@KevinJump KevinJump linked a pull request Mar 22, 2022 that will close this issue
Fix #372 - also return true when we find the parent but don't set it. #373
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinJump KevinJump

Labels
v9/9.3.0
Projects
None yet
Milestone
9.3.0 - Single pass improvements
Development

Successfully merging a pull request may close this issue.

Fix #372 - also return true when we find the parent but don't set it. KevinJump/uSync
1 participant
@KevinJump