Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fails on config files of True/False values pre Umbraco v8.8.0 #436

Closed
KevinJump opened this issue Nov 14, 2022 · 1 comment
Closed
Assignees

Comments

@KevinJump
Copy link
Owner

From : https://our.umbraco.com/packages/developer-tools/usync/usync/110465-import-fail-could-not-convert-string-to-boolean-0-path-default-line-2-pos

if you import a true/false value that was generated pre Umbraco 8.8.0 onto a site running Umbraco 8.8+ it fails:

`Import Fail: Could not convert string to boolean: 0 Path 'Default', line 2, pos....`


this is because of breaking change #8477 in Umbraco released in Umbraco 8.4

pre v8.8

{
  "Default": null,
  "Label": null
}

8.8.0+

{
  "Default": false,
  "ShowLabels": false,
  "LabelOn": null,
  "LabelOff": null
}

the key culprit is the change of Default from string to bool, and the Json serializer can't serialize a null into a bool.

@KevinJump
Copy link
Owner Author

Fixed in 8.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant