Ensure we put cultures in for null values, even when they are not there. #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinJump
added a commit
that referenced
this pull request
Mar 29, 2023
KevinJump
added a commit
that referenced
this pull request
Mar 29, 2023
* Add RequiredAdmin to ISyncAdd on - so we can hide uSync tabs. * Change to HideAddOns setting - simpler less dependencies. * Fix: SignalR root missing on first install/upgrade (#482) * Add support for Domain Sort order in v11.3 (#481) * Add support for Domain Sort order in v11.3 * Clean the using statements for these two files. * re-instate lookup by key value (used only in uSync.Complete). (#485) * Ensure we put cultures in for null values, even when they are not there. (#486) * Tidy: Comment warning fix. * Add logging - to log when someone runs something. * Update: Make sure we include blank cultures when only some values are set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that properties that are null but have culture values are consistently serialized.
When an item is saved in the backoffice, blank property values are present in the model, and so uSync Serializes them with the culture values .
however when the object is retrieved from the Umbraco API these values are not set at all, previously we just added a null value but without the culutre.
this fix adds a null value for all available cultures in a node.
This will change some output of existing files - so should be a minor bump of version number.