Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the "nonzero is not supported for tensors with more than INT_MAX elements" in get_all_triplets_indices #689

Merged
merged 2 commits into from Apr 1, 2024

Conversation

mkmenta
Copy link
Contributor

@mkmenta mkmenta commented Mar 8, 2024

This solves #688

@mkmenta
Copy link
Contributor Author

mkmenta commented Mar 8, 2024

I am not sure if there could be other places where changing the torch.where could be beneficial (in case this implementation is accepted).

I think that in get_all_pairs_indices it would be hard to have a tensor with INT_MAX elements because the tensors used in the torch.where in this case are just len(labels)*len(ref_labels).

@KevinMusgrave
Copy link
Owner

Thanks!

@KevinMusgrave KevinMusgrave merged commit cfafd3b into KevinMusgrave:dev Apr 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants