Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added arrIncludes and arrIncludesAll to multi-select filters #300

Conversation

alessandrojcm
Copy link
Collaborator

@alessandrojcm alessandrojcm commented Mar 31, 2024

  • Added arrIncludesAll and arrIncludesSome for multi-select filter
  • Fixed a bug that caused the table to crash when switching from empty/non-empty filters to arr* filters
  • Added clearable option to multi-select
  • Removed clear button from the empty/non-empty pill as it was not working and the filtering can be removed by just using the option menu

Closes #296

@alessandrojcm alessandrojcm added bug Something isn't working V2 Issue with MRT V2 labels Mar 31, 2024
@alessandrojcm alessandrojcm self-assigned this Mar 31, 2024
Copy link

vercel bot commented Mar 31, 2024

@alessandrojcm is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@alessandrojcm alessandrojcm force-pushed the 296-multiselect-array-filtering-modes-no branch from c195d79 to 7ddd2be Compare March 31, 2024 18:59
@alessandrojcm alessandrojcm changed the title 296 multiselect array filtering modes no Added arrIncludes and arrIncludesAll to multi-select filters Mar 31, 2024
@KevinVandy
Copy link
Owner

I'm not too sure about these changes? I'm not sure array filter methods belong along-side by default with the other filter modes.

@alessandrojcm
Copy link
Collaborator Author

@KevinVandy what do you think we should do? The issue here is that the filter mode prop typing does accept the arr* filter modes as valid, so imo having the table accept those modes and then do nothing with them seems like a bug.

@alessandrojcm alessandrojcm deleted the 296-multiselect-array-filtering-modes-no branch April 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V2 Issue with MRT V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiselect array filtering modes not usable
2 participants