Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The path to the types in the package.json for the locale is incorrect. #340

Closed
wants to merge 1 commit into from

Conversation

mintaka2479
Copy link
Contributor

This might be the reason why a complete import path is required in Remix and similar frameworks.

Note: In some frameworks like Remix, you may need to use a full import path like
import { MRT_Localization_ES } from 'mantine-react-table/locales/es/index.js'; or
import { MRT_Localization_ES } from 'mantine-react-table/locales/es/index.esm.js';
to properly import the locale.

Copy link

vercel bot commented Jun 1, 2024

@mintaka2479 is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@alessandrojcm
Copy link
Collaborator

I tried this locally from a Remix app but I am still getting the type errors, could you please confirm it works with a codesandbox or similar? If I am not mistaken this is a ESM requirement anyway so I do not think it is a typings issue.

@mintaka2479
Copy link
Contributor Author

This problem is difficult. PR is closed.

@mintaka2479 mintaka2479 closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants