Consider date-range as range filter in filter label #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattwcole is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @mattwcole thanks for this. Yes please open a PR for v2 as well if you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting column definition property
filterVariant: "date-range"in combination with a customfilterFn, the filter icon and tooltip are incorrectly shown, even when no filter has been applied.The filter label currently only displays properly if the
filterFnis one of the built in values['between', 'betweenInclusive', 'inNumberRange']. This change makesdate-rangealways be considered as a range filter, regardless of the filter function.The bug appears to exist in v2 also, I'd be happy to put up another PR if required.