Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Range slider, additional useEffect dependencies (#573)
This commit adds min and max values to useEffect dependencies. The change relates to an issue with multiple render cycles, for example while updating table's input data over time before user has a chance to interact with the sliders. If client code updates the table's data set, that triggers another render. If the original data set (on the first render of the component) had zero rows, then filterValues will be set to [0,0] indefinitely (and makes the slider heads appear over each others in zero position) until the user manipulates the sliders in the UI. If the client code pushes in a new data set before the user manipulates the slider in the UI, filterValues will not be updated, since the useEffect does not listen to it, and useState's initial value is set only on the first render. The issue is fixed when user ends a slider drag in the UI, which in turn triggers onChangeCommitted, which calls column.setFilterValue, which sets up the sliders correctly.
- Loading branch information
020806f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
material-react-table-storybook – ./
material-react-table-storybook-kevinvandy.vercel.app
material-react-table-storybook-git-main-kevinvandy.vercel.app
material-react-table.dev
www.material-react-table.dev
material-react-table-storybook.vercel.app
020806f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
material-react-table – ./apps/material-react-table-docs
material-react-table-git-main-kevinvandy-s-team.vercel.app
www.material-react-table.com
material-react-table.vercel.app
material-react-table-kevinvandy-s-team.vercel.app
material-react-table.com