Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed global filter when manual paginating #307

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

duckboy81
Copy link
Contributor

Problem:
If manualPagination is true, the current rows function for the TableBody component improperly performs a slice on the search results.

Proposed fix:
The user is already handling pagination manually, there is no need to perform an additional slice to accommodate the default pagination logic.

Problem:
If `manualPagination` is `true`, the current `rows` function for the `TableBody` component improperly performs a `slice` on the search results.

Proposed fix:
The user is already handling pagination manually, there is no need to perform an additional slice to accommodate the default pagination logic.
@vercel
Copy link

vercel bot commented Jan 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
material-react-table ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 10, 2023 at 3:31AM (UTC)
material-react-table-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 10, 2023 at 3:31AM (UTC)

@KevinVandy KevinVandy merged commit c10419b into KevinVandy:main Jan 10, 2023
@KevinVandy
Copy link
Owner

this is now released in v1.5.5

@duckboy81 duckboy81 deleted the patch-3 branch January 11, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants