Move columnOrder spread in columnReorder #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some scenarios the splice will throw an exception if columnOrder is readOnly. Moving the columnOrder spread before the splice fixes the issue.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Would you be able to share an example of when this happens. Well probably merge, but want to understand the problem fully first. |
|
It seems to happen only when I manage the columnOrder state: |
KevinVandy
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios the splice will throw an exception if columnOrder is readOnly. Moving the columnOrder spread before the splice fixes the issue.