Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export DensityState type #90

Merged
merged 1 commit into from Sep 17, 2022

Conversation

gioqw
Copy link
Contributor

@gioqw gioqw commented Sep 17, 2022

Sorry for making all these tiny PRs, is it better for you to have PRs aggregated before or do you prefer to keep features apart also in PRs?

Best,
Gio

@vercel
Copy link

vercel bot commented Sep 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
material-react-table ✅ Ready (Inspect) Visit Preview Sep 17, 2022 at 7:17AM (UTC)
material-react-table-storybook ✅ Ready (Inspect) Visit Preview Sep 17, 2022 at 7:17AM (UTC)

@KevinVandy
Copy link
Owner

Sorry for making all these tiny PRs, is it better for you to have PRs aggregated before or do you prefer to keep features apart also in PRs?

Best, Gio

It is best OSS practice to have many small PRs, so that maintainers can better pick and choose what to accept, and be able to give focussed feedback on any requested changes

@KevinVandy KevinVandy merged commit 4928dde into KevinVandy:main Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants