Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean logs and create a custom Logger #29

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Clean logs and create a custom Logger #29

merged 5 commits into from
Oct 21, 2023

Conversation

KevinnZou
Copy link
Owner

@DatL4g I cleaned unused logs and created a custom logger. For testing, we can set the minSeverity to Debug and then change it to Info before publishing to prevent users from seeing test logs.

@KevinnZou KevinnZou added the enhancement New feature or request label Oct 16, 2023
@KevinnZou KevinnZou requested a review from DatL4g October 16, 2023 12:45
@KevinnZou KevinnZou self-assigned this Oct 16, 2023
@KevinnZou KevinnZou linked an issue Oct 16, 2023 that may be closed by this pull request
Copy link
Collaborator

@DatL4g DatL4g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now.

Please add a method to the WebViewState where we can specifiy the severity and/or a custom logger. (Whatever you like more)
This way the user can decide the logging process and we don't have to switch the type for release, instead we can just specifiy the debug severity in the basic example methods

@KevinnZou
Copy link
Owner Author

Looks good for now.

Please add a method to the WebViewState where we can specifiy the severity and/or a custom logger. (Whatever you like more) This way the user can decide the logging process and we don't have to switch the type for release, instead we can just specifiy the debug severity in the basic example methods

@DatL4g Thanks for your suggestions! I added the method in WebSetting which I think is more suitable than WebViewState. Please let me know if any further changes are needed.

@KevinnZou KevinnZou merged commit 7e22908 into main Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging Interceptor
2 participants