Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jcef to latest version and KCEF for improved custom request context handler #83

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

DatL4g
Copy link
Collaborator

@DatL4g DatL4g commented Jan 7, 2024

No description provided.

@KevinnZou KevinnZou self-assigned this Jan 8, 2024
@KevinnZou KevinnZou added the enhancement New feature or request label Jan 8, 2024
@KevinnZou
Copy link
Owner

@DatL4g Great Job! Thank you so much!

@KevinnZou KevinnZou merged commit 75c80e7 into KevinnZou:main Jan 8, 2024
4 checks passed
@KevinnZou
Copy link
Owner

@DatL4g One issue I encountered is that you are using the KCEFResourceRequestHandler for request interception. However, it only has the onBeforeResourceLoad method, which will be called multiple times for a single URL request. Is it possible to provide the CefRequestHandlerAdapter instead, so that we can override the onBeforeBrowse method, which will only be called once for each URL request?

@DatL4g
Copy link
Collaborator Author

DatL4g commented Jan 8, 2024

@KevinnZou this should be no problem now. You can call this method on the client addRequestHandler

@KevinnZou
Copy link
Owner

KevinnZou commented Jan 9, 2024

@DatL4g So the issue you mentioned in this link has been solved? It appears that you have provided a default CefResourceRequestHandler, but the default CefRequestHandler is still missing. So should the same problem still exist if we just call addRequestHandler which will override the default implementation?

Update: I have tested it with the latest KECF version and confirmed that the problem still exists. You can find the test code here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants