Fix Laravel Cache storage: set empty string als default value #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herpaderpaldent
changed the title
bytestream
approved these changes
Sep 2, 2022
Kevinrob
approved these changes
Oct 2, 2022
|
@Kevinrob any chance of tagging a new release? 🤞 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default cache return
nullif key is not present.The current implementation will cause the following error notice:
PHP Deprecated: unserialize(): Passing null to parameter #1 ($data) of type string is deprecated in /var/www/html/vendor/kevinrob/guzzle-cache-middleware/src/Storage/LaravelCacheStorage.php on line 32By setting an empty string as default,
unserialisewill no longer throw the error notice