use __serialize instead of __sleep on CacheEntry #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@e-zannelli Can you rebase it? We have now Gitub Actions with tests |
e-zannelli
force-pushed
the
fix/serialize-cache-entry
branch
from
8598883
to
f914a07
Compare
|
Rebased 🙇 |
Thank you! The tests don't pass 😯 |
|
Ah, __serialize is a php 7.4 feature and you still support php 7.2 |
e-zannelli
force-pushed
the
fix/serialize-cache-entry
branch
from
f914a07
to
222b2ed
Compare
|
I restored compatibility with php <7.4 by implementing \Serializable interface, tests pass now. |
Kevinrob
reviewed
May 27, 2023
Comment on lines
+324
to
+327
| public function unserialize($data) | ||
| { | ||
| $this->__unserialize(unserialize($data)); | ||
| } |
There was a problem hiding this comment.
What is the purpose of this function public function unserialize($data)? I don't find any call to it and it doesn't seem to be a "magic" PHP function.
There was a problem hiding this comment.
It's from PHPs legacy system for customized serialization, see: The Serializable interface
|
Thanks @e-zannelli ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed fix for #162