Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see SVGs in IE9 via localhost:PORT #29

Closed
mahboob-awan opened this issue Nov 11, 2016 · 4 comments
Closed

Can't see SVGs in IE9 via localhost:PORT #29

mahboob-awan opened this issue Nov 11, 2016 · 4 comments

Comments

@mahboob-awan
Copy link

Hi, Thanks for writing this useful polyfill. Good job 聽馃憤

We are unable to see SVGs locally for IE9 and fixed the problem using following change

if (Request.withCredentials === undefined && origin2 !== '' && origin2 !== ':' && origin2 !== origin)

at svgxuse.js#L64

Kindly correct us if something done wrong, or update the actual file, so it will safe other. Thanks

@mahboob-awan
Copy link
Author

#28

@Keyamoon
Copy link
Owner

Hi,

I'm not quite sure if this is necessary. I suspect you're using URLs in the form of ":8080/example.svg" in your xlink-href? I can't reproduce any other situation where origin would become :. If you add "localhost" to your URLs, it should solve the problem.

@mahboob-awan
Copy link
Author

Please consider more detail:

<use xlink:href="/static/xxx/icons/sprite/svg-sprite.svg#icon-test"/>

and site may run at localhost:8080 OR localhost:9898 OR localhost:8888

and Developer always test his/her changes at IE9 using localhost:PORT.

Keyamoon added a commit that referenced this issue Nov 11, 2016
@Keyamoon
Copy link
Owner

Version 1.1.23 should solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants