Invalid setAttributeNS syntax

[ramijarrar]

You need to specify the qualified name (i.e 'xlink:href' not 'href') when using setAttributeNS.

[ramijarrar]

Note that getAttributeNS takes the local name so your current implementation for that is correct.

See the API for both here and here

[Keyamoon]

What was the point in opening this issue then?

[ramijarrar]

See my first comment above, the issue is with the setAttributeNS syntax I was just pointing out that this issue does not also apply to getAttributeNS.

[ramijarrar]

In other words this line of code uses the wrong syntax:

uses[i].setAttributeNS(xlinkNS, 'href', '#' + hash);

It needs to look like this:

uses[i].setAttributeNS(xlinkNS, 'xlink:href', '#' + hash);

[Keyamoon]

The prefix in the qualified name seems to be optional though: http://www.w3.org/TR/1999/REC-xml-names-19990114/#ns-qualnames

And when I tested the demo in IE 9 and 10, there was no issue. Have you encountered any issues with the current setAttibuteNS?

[ramijarrar]

It is reported here that this can cause issues in Chrome.

[Keyamoon]

Fair enough. I will add the prefix in a moment.

[ramijarrar]

Btw - since the polyfill only activates in IE leaving it probably won't do any harm, but I guess it's better to err on the side of caution.

[Keyamoon]

I agree. It can't hurt. I just tested it in IE again to make sure the addition of the prefix won't cause issues.