tests: added data file and test coverage to demonstrate encodings #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library uses fs.createReadStream to read files when fromFile is called and passes through options, including encoding, to the fs call. This is not obvious, resulting in issue Keyang#402. I have added a test to demonstrate this capability and a data file encoded in latin1 for use in the test. Issue Keyang#402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library uses
fs.createReadStreamto read files when fromFileis called and passes through options, including encoding, to the
fs call. This is not obvious, resulting in issue #402. I have added
a test to demonstrate this capability and a data file encoded in
latin1 for use in the test.
Issue #402