Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow username and password while generating certificate from ejbca #56

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

adityajoshi12
Copy link
Contributor

Describe your changes

This PR has changeset for the ejbca_certificate module to allow users to pass custom username and password parameters.

How has this been tested?

Tested locally

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have kept the patch limited to only change the parts related to the patch
  • This change requires a documentation update

See also Contributing Guidelines.

Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>
@adityajoshi12
Copy link
Contributor Author

@svenska-primekey @primetomas , can you please review this PR?

@svenska-primekey
Copy link
Collaborator

I was out on vacation, I will review this PR. Thanks for sharing!

@svenska-primekey svenska-primekey self-requested a review July 8, 2024 15:11
@svenska-primekey svenska-primekey self-assigned this Jul 8, 2024
@svenska-primekey svenska-primekey added the enhancement New feature or request label Jul 8, 2024
@svenska-primekey svenska-primekey merged commit b5d32a9 into Keyfactor:main Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants