Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site unusable on mobile. #163

Open
CalebAlbers opened this issue Jul 30, 2016 · 2 comments
Open

Site unusable on mobile. #163

CalebAlbers opened this issue Jul 30, 2016 · 2 comments
Labels

Comments

@CalebAlbers
Copy link

Please work on implementing a mobile-first design methodology. The current site's JavaScript and CSS is buggy for those on mobile or viewing with smaller screens. Touchscreen functionality is limited as well

Reach out to me if you need any help with design or front-end dev. That's my thing.

Thanks!
screenshot_20160729-192939

jsiems added a commit that referenced this issue Aug 1, 2016
@jsiems
Copy link
Contributor

jsiems commented Aug 1, 2016

Hey Caleb,

We forgot to create a css rule for the admin image for mobile, which is why it was all out of whack. It has been fixed on my branch.

Also the https insecurity is interesting because it appears the certificate that was bought for that site is not trusted by most cellphone browsers. We have been looking in to that.

I would like you to look over my branch of the site and make sure that all the issues you noticed were fixed before I request to push it to production. check it out here

Thanks for you feedback!

@CalebAlbers
Copy link
Author

No worries. The admin image problem is fixed. The CSS could use some more breakpoints for better behavior on devices with smaller screen width, however.

800px

Consider the behavior at 800px width exactly:
screen shot 2016-08-01 at 18 18 21

The question submission section looks a bit odd, however you can still scroll and see other questions:
screen shot 2016-08-01 at 18 18 28

<800px

Now at anything below 800px (in this case, I changed to 799px width), you get the following:

screen shot 2016-08-01 at 18 19 03

In this case, you cannot scroll down to see the questions. Looking at the CSS and, more specifically, the .newQuestionContainer class, you have a position: fixed along with z-index: 1 and height: 400px as shown below:

.newQuestionContainer {
    background-color: white;
    height: 400px;
    position: fixed;
    top: 200px;
    transition: top 0.2s ease-in-out 0s;
    width: 100%;
    z-index: 1;
}

My suggestion (which is worth $0.02 with inflation) would be to ditch static heights and go based on viewport instead (relative percentages or em based on current font size) . Additionally, it may be worth looking at defining things by width instead of by height. That would allow use of CSS values like display: inline-block.

Just food for thought. You guys are on the right track.

Thanks!

s1037989 added a commit that referenced this issue Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants