Rust msgpacked value #146
Merged
Rust msgpacked value #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
reviewed
Apr 17, 2020
|
|
||
| const size_t data_size = msgpacked_value.size(); | ||
| auto data_ptr = malloc(data_size); | ||
| memcpy(data_ptr, msgpacked_value.c_str(), data_size); |
There was a problem hiding this comment.
I am missing some checks:
- what if msgpacked_value has size 0 (key-only dictionary, empty match)
- malloc could return NULL on error
There was a problem hiding this comment.
@hendrikmuhs thx!
addressed them here ee0f081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added functionality to get internal msgpacked on rust end